Skip to content

Make sure resonate.get works #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Make sure resonate.get works #215

merged 2 commits into from
Apr 30, 2025

Conversation

avillega
Copy link
Contributor

No description provided.

@avillega avillega requested review from dfarr and Tomperez98 April 29, 2025 23:21
@avillega
Copy link
Contributor Author

Before this changes, resonate.get() was kind of working. This changes make use of the store.get that was recently added and adds some tests.

@avillega avillega force-pushed the avillega/resonate-get branch from 40d35be to f2c5230 Compare April 29, 2025 23:23
@avillega avillega force-pushed the avillega/resonate-get branch from f2c5230 to c40d0a4 Compare April 30, 2025 22:19
@avillega avillega linked an issue Apr 30, 2025 that may be closed by this pull request
@avillega avillega requested a review from dfarr April 30, 2025 22:20
@avillega
Copy link
Contributor Author

This is ready for review.

Copy link
Collaborator

@Tomperez98 Tomperez98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avillega avillega merged commit 9e54e4e into main Apr 30, 2025
8 checks passed
@avillega avillega deleted the avillega/resonate-get branch April 30, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resonate.get()
3 participants