Skip to content

Implement rpc and listen #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

Implement rpc and listen #183

merged 2 commits into from
Apr 22, 2025

Conversation

avillega
Copy link
Contributor

Resolves #182

@avillega avillega requested review from dfarr and Tomperez98 April 21, 2025 23:25
dfarr
dfarr approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we can just make the one change regarding the assertion

@avillega avillega merged commit b79659d into main Apr 22, 2025
1 check passed
@avillega avillega deleted the avillega/handle-subs branch April 22, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfarr dfarr dfarr approved these changes

@Tomperez98 Tomperez98 Tomperez98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle subscriptions and Listening correctly on the bridge
3 participants
@avillega @dfarr @Tomperez98