-
Notifications
You must be signed in to change notification settings - Fork 778
docs: Move react-email
to dev dependencies in install guides
#1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Move react-email
to dev dependencies in install guides
#1522
Conversation
@PCRinus is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
8a41d44
to
a0a0c9a
Compare
ab9ef34
to
0908efb
Compare
e001f5e
to
f5cf05c
Compare
a97d9fa
to
e4e1e6e
Compare
d1a7c8d
to
296473d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make all --save-dev
flags into just the shorthand form, i.e., -D
?
e4e1e6e
to
e974fe1
Compare
|
`react-email` can be installed as a dev dependency, instead of a dependency that we need to ship at runtime, thus saving bundle space
e974fe1
to
05fb2c5
Compare
@gabrielmfern Sorry for the delay, I've changed all the dev flags to their shorthand version. I would keep the Also, do we need to generate a changeset for this small change? |
Thanks for making the changes!
Nope, changeset is only meant for when changing something in a package that would require a subsequent versioning change. |
react-email
can be installed as a dev dependency, instead of a dependency that we need to ship at runtime, thus saving bundle space. Adjust the documentation for all package managers to reflect this.This has been mentioned initially in this issue thread: #1101
Side by side comparison