Skip to content

feat(head): iOS formatting meta tag as default #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 28, 2024
Merged

feat(head): iOS formatting meta tag as default #1369

merged 8 commits into from
Mar 28, 2024

Conversation

endymion1818
Copy link
Contributor

@endymion1818 endymion1818 commented Mar 18, 2024

Meant to deal with #671. Since iOS is one of the most common renderers I figured it would make sense to add this as a default, especially since it is specific to that client it won't adversely affect any other clients.

Fixes #671. Since iOS is one of the most common renderers I figured it would make sense to add this as a default, especially since it is specific to that client it won't adversely affect any other clients.
Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 11:06am

Copy link

vercel bot commented Mar 18, 2024

@endymion1818 is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@endymion1818
Copy link
Contributor Author

I'm having trouble with running tests locally, I keep getting the following error

Error: Failed to resolve entry for package "@react-email/render". The package may have incorrect main/module/exports specified in its package.json.

@gabrielmfern
Copy link
Collaborator

Love this! Thank you so much for the PR.

@endymion1818 Can you try running pnpm build at the root (which will run turbo build)?
Some packages use other packages on the workspace for their tests, so you need to build them all before running their tests.

@gabrielmfern gabrielmfern changed the title fix(packages/head): #671 add iOS formatting meta tag as default fix(head): #671 add iOS formatting meta tag as default Mar 27, 2024
@gabrielmfern gabrielmfern changed the title fix(head): #671 add iOS formatting meta tag as default feat(head): iOS formatting meta tag as default Mar 27, 2024
@gabrielmfern gabrielmfern merged commit 2092215 into resend:canary Mar 28, 2024
bukinoshita pushed a commit that referenced this pull request Apr 3, 2024
Co-authored-by: Benny Burrito <[email protected]>
Co-authored-by: Ben Verspeak <[email protected]>
Co-authored-by: Gabriel Miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Apr 26, 2024
Co-authored-by: Benny Burrito <[email protected]>
Co-authored-by: Ben Verspeak <[email protected]>
Co-authored-by: Gabriel Miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Apr 26, 2024
Co-authored-by: Benny Burrito <[email protected]>
Co-authored-by: Ben Verspeak <[email protected]>
Co-authored-by: Gabriel Miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Apr 26, 2024
Co-authored-by: Benny Burrito <[email protected]>
Co-authored-by: Ben Verspeak <[email protected]>
Co-authored-by: Gabriel Miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Apr 29, 2024
Co-authored-by: Benny Burrito <[email protected]>
Co-authored-by: Ben Verspeak <[email protected]>
Co-authored-by: Gabriel Miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Apr 29, 2024
Co-authored-by: Benny Burrito <[email protected]>
Co-authored-by: Ben Verspeak <[email protected]>
Co-authored-by: Gabriel Miranda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants