Skip to content

fix(markdown, components): bump md-to-react-email to v5.0.2 #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2024
Merged

fix(markdown, components): bump md-to-react-email to v5.0.2 #1355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d43167d
fix(markdown): bump md-to-react-email, add tests
lordelogos Mar 13, 2024
79f8c5a
feat(components): bump @react-email/markdown
lordelogos Mar 13, 2024
49f9a92
revert: bump down package versions
lordelogos Mar 13, 2024
f163629
Merge branch 'canary' into fix/markdown
lordelogos Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/markdown/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@
"typescript": "5.1.6"
},
"dependencies": {
"md-to-react-email": "5.0.0"
"md-to-react-email": "5.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/markdown/src/__snapshots__/markdown.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ exports[`<Markdown> component renders correctly > renders lists in the correct f
`;

exports[`<Markdown> component renders correctly > renders text in the correct format for browsers 1`] = `
"<!DOCTYPE html PUBLIC \\"-//W3C//DTD XHTML 1.0 Transitional//EN\\" \\"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\\"><div data-id=\\"react-email-markdown\\"><p><strong style=\\"font-weight:bold\\">This is sample bold text in markdown</strong> and <em style=\\"font-style:italic\\">this is italic text</em></p>
"<!DOCTYPE html PUBLIC \\"-//W3C//DTD XHTML 1.0 Transitional//EN\\" \\"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\\"><div data-id=\\"react-email-markdown\\"><p><strong style=\\"font:700 23px / 32px &#x27;Roobert PRO&#x27;, system-ui, sans-serif;background:url(&#x27;path/to/image&#x27;)\\">This is sample bold text in markdown</strong> and <em style=\\"font-style:italic\\">this is italic text</em></p>
</div>"
`;

Expand Down
9 changes: 8 additions & 1 deletion packages/markdown/src/markdown.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,14 @@ console.log(\`Hello, $\{name}!\`);

it("renders text in the correct format for browsers", () => {
const actualOutput = render(
<Markdown>
<Markdown
markdownCustomStyles={{
bold: {
font: '700 23px / 32px "Roobert PRO", system-ui, sans-serif',
background: 'url("path/to/image")',
},
}}
>
**This is sample bold text in markdown** and *this is italic text*
</Markdown>,
);
Expand Down
113 changes: 12 additions & 101 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.