feat(react-email, create-email): Use internal implementation for tree function instead of using tree-cli
#1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
gabrielmfern
force-pushed
the
feat/internal-implementation-of-tree
branch
from
2645296 to
9fe0350
Compare
gabrielmfern
force-pushed
the
feat/internal-implementation-of-tree
branch
from
9fe0350 to
8f8c645
Compare
|
Hey @gabrielmfern, are we just waiting for a review to get this merged? Anything I can do to help? |
vcapretz
previously approved these changes
Feb 27, 2024
vcapretz
approved these changes
Feb 27, 2024
|
@michaelhays Hey, heads up, we just released this under |
|
Thank you sir! I'll try them out! |
gabrielmfern
added a commit
that referenced
this pull request
Mar 6, 2024
… function instead of using `tree-cli` (#1221)
|
Following up, 2.1.1 no longer gives me the Snyk warnings 🙏 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
Some time ago we switched from using
tree-node-clito usingtree-cliastree-node-cliwas causingissues for someone trying to download the CLI behind a corporate proxy.
The new library
tree-clithough is unmaintained and seems to depend on some librariesthat were being caught by some security measures mentioned here #1153.
This fixes this by having our implementation of the tree functionality
both in
create-emailand inreact-emailwhich is not very hard to maintainand comes along with tests to verify this works properly.
How can I test to make sure it's fixed?
node src/index.jsinside of./packages/create-emailIf you try running the
exportcommand from the CLI, which is the other place that depends onthis
treefunctionality, you will probably have an error here which #1214 fixes.Closes #1153