Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Pipe reformat eats annotation #629

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Pipe reformat eats annotation #629

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7597c4
Add example of pipe reformat eating annotation
cristianoc Sep 1, 2022
1d000e2
Turns out `|>` has the same problem.
cristianoc Sep 1, 2022
3fec13e
Fir reformatting issue for `->` and `|>`.
cristianoc Sep 1, 2022
6e87459
Tweak test to show the difference between -> or |> and ** in printing.
cristianoc Sep 2, 2022
e27f1be
Check if there are printable attributes in pipe.
cristianoc Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
- Initial support for JSX V4, still work in progress.
- :boom: when V4 is activated, at most one component is allowed for each module.

#### :bug: Bug Fix

- Fix issue where the printer would omit attributes for `->` and `|>` https://github.com/rescript-lang/syntax/pull/629

## ReScript 10.0

- Fix printing for inline nullary functor types [#477](https://github.com/rescript-lang/syntax/pull/477)
Expand Down
1 change: 1 addition & 0 deletions src/res_printer.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3658,6 +3658,7 @@ and printBinaryExpression ~customLayout (expr : Parsetree.expression) cmtTbl =
Doc.group
(Doc.concat
[
printAttributes ~customLayout expr.pexp_attributes cmtTbl;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seen this one before perhaps?
https://github.com/rescript-lang/syntax/pull/621/files#diff-5f509cef22744d6c22d0c7a7fc37bcb68a1bda23db28caa9dc2b20cdbfebb695R3661

lhsDoc;
(match (lhsHasCommentBelow, op) with
| true, "|." -> Doc.concat [Doc.softLine; Doc.text "->"]
Expand Down
3 changes: 3 additions & 0 deletions tests/printer/expr/expected/pipe.res.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
let s1 = @ann x->foo
let s2 = @ann foo(x)
let s3 = @ann x |> foo
3 changes: 3 additions & 0 deletions tests/printer/expr/pipe.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
let s1 = @ann (x->foo)
let s2 = @ann (foo(x))
let s3 = @ann (x|>foo)