Skip to content

Change %mulint primitive behavior #7358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2025

Conversation

cometkim
Copy link
Member

No description provided.

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good to me!
(But @cristianoc should definitely have a look, too.)

@cristianoc
Copy link
Collaborator

Looks good: could you make the description a bit more specific.
Eg treat int32 mul as other other multiplication instead of using Math.imul

@cometkim
Copy link
Member Author

Looks good: could you make the description a bit more specific.
Eg treat int32 mul as other other multiplication instead of using Math.imul

Done

@cometkim cometkim merged commit ff57030 into rescript-lang:master Mar 23, 2025
20 checks passed
@cometkim cometkim deleted the int-mul-truncate branch March 23, 2025 15:05
fhammerschmidt pushed a commit that referenced this pull request Apr 4, 2025
* Change `%mulint` primitive behavior

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants