Add `throw` #7346

aspeddro · 2025-03-17T13:16:03Z

Deprecate raise and rename references.

Deprecate `raise` and rename references

aspeddro · 2025-03-17T13:20:21Z

runtime/Stdlib_Exn.res

Should we add @@deprecated to this module?

It has the same content as https://github.com/rescript-lang/rescript/blob/master/runtime/Stdlib_Error.res

it doesn't have exactly the same content though, Error is missing the definition of a JS exception that today is catched with Exn.Error(obj), but I agree the current situation is not ideal, maybe we could merge the two?

I will explore this in another PR

tsnobip

thanks for doing this @aspeddro, I think that's a nice improvement. I'm just not sure if we should also deprecate raise, having both without any explanation feels a bit weird to me. I'm also not sure about what we should do for Stdlib.Exn module, but I'd advise to keep this work for another PR to avoid bikeshedding on this topic.

tsnobip · 2025-03-17T20:08:27Z

runtime/Pervasives_mini.res

@@ -1,5 +1,6 @@
 /* Exceptions */
 external raise: exn => 'a = "%raise"


should we deprecate raise or keep both for now?

I will remove

aspeddro · 2025-03-17T23:16:25Z

We can add to deprecated attribute?

raise has been renamed to throw to align with JavaScript vocabulary. Please use throw.

cknitt · 2025-03-19T07:51:47Z

runtime/Stdlib.res

@@ -100,6 +100,7 @@ async function main() {
 external import: 'a => promise<'a> = "%import"

 let panic = Error.panic
+let throw = Error.throw


This is not zero-cost (causes a $$throw function to be emitted in Stdlib.js). I am afraid we need to repeat the external definition here.

aspeddro · 2025-03-19T16:24:57Z

runtime/Stdlib.res

+}
+```
+*/
+external throw: Error.t => 'a = "%raise"


Should I add the external here or just leave it in the Stdlib_Error.res module?

Maybe clearer to add it in Pervasives on top of the deprecated raise instead?

aspeddro · 2025-03-20T19:16:17Z

CHANGELOG updated

cknitt · 2025-03-21T12:55:30Z

@aspeddro did you see my comment?

Should I add the external here or just leave it in the Stdlib_Error.res module?

Maybe clearer to add it in Pervasives on top of the deprecated raise instead?

aspeddro · 2025-03-21T13:38:17Z

@aspeddro did you see my comment?

Should I add the external here or just leave it in the Stdlib_Error.res module?

Maybe clearer to add it in Pervasives on top of the deprecated raise instead?

Yes, I will adjust

fhammerschmidt · 2025-03-21T16:05:27Z

Should we also have a throws decorator as an alias to raises in reanalyze?

cristianoc · 2025-03-21T16:11:46Z

Should we also have a throws decorator as an alias to raises in reanalyze?

Good idea.

cknitt · 2025-03-23T09:50:35Z

runtime/Pervasives.res

@@ -1,6 +1,6 @@
 /**
   Since [others] depend on this file, its public mli files **should not
-   export types** introduced here, otherwise it would cause 
+   export types** introduced here, otherwise it would cause


This whole comment is obsolete and should be removed as there is no others folder anymore (leftover from the old stdlib build procedure).

Or actually, there should be a module-level doc comment (/***) instead explaining what the Pervasives module is.

Comment removed a36b71d

runtime/Pervasives.res

runtime/Stdlib_Error.resi

Co-authored-by: Christoph Knittel <[email protected]>

* Add `throw` Deprecate `raise` and rename references * remove raise from Pervasives_mini.res * convert to external and add deprecated attr * restore tests/gentype_tests/typescript-react-example/package-lock.json * update analysis output * update CHANGELOG.md * move `throw` to Pervasives.res * Update runtime/Pervasives.res Co-authored-by: Christoph Knittel <[email protected]> * Update runtime/Pervasives.res Co-authored-by: Christoph Knittel <[email protected]> * Update runtime/Pervasives.res Co-authored-by: Christoph Knittel <[email protected]> * Update runtime/Stdlib_Error.resi Co-authored-by: Christoph Knittel <[email protected]> * Update runtime/Stdlib_Error.resi Co-authored-by: Christoph Knittel <[email protected]> * Update runtime/Stdlib_Error.resi Co-authored-by: Christoph Knittel <[email protected]> * update Stdlib_Bool and Stdlib_Char * remove comment --------- Co-authored-by: Christoph Knittel <[email protected]>

Add throw

835efe4

Deprecate `raise` and rename references

aspeddro commented Mar 17, 2025

View reviewed changes

tsnobip approved these changes Mar 17, 2025

View reviewed changes

remove raise from Pervasives_mini.res

0061043

cknitt reviewed Mar 19, 2025

View reviewed changes

aspeddro added 3 commits March 19, 2025 13:00

convert to external and add deprecated attr

54a06c9

restore tests/gentype_tests/typescript-react-example/package-lock.json

ad6cd69

update analysis output

69ebdca

aspeddro commented Mar 19, 2025

View reviewed changes

aspeddro added 2 commits March 20, 2025 15:47

update CHANGELOG.md

cad9455

Merge branch 'master' into raise-to-throw

98cc917

aspeddro requested a review from cknitt March 20, 2025 19:16

move throw to Pervasives.res

86ee1d1

cknitt reviewed Mar 23, 2025

View reviewed changes

aspeddro and others added 9 commits March 24, 2025 18:47

Update runtime/Pervasives.res

9a4c60b

Co-authored-by: Christoph Knittel <[email protected]>

Update runtime/Pervasives.res

cafdbed

Co-authored-by: Christoph Knittel <[email protected]>

Update runtime/Pervasives.res

aa214cd

Co-authored-by: Christoph Knittel <[email protected]>

Update runtime/Stdlib_Error.resi

3de6771

Co-authored-by: Christoph Knittel <[email protected]>

Update runtime/Stdlib_Error.resi

86860f1

Co-authored-by: Christoph Knittel <[email protected]>

Update runtime/Stdlib_Error.resi

263f9fd

Co-authored-by: Christoph Knittel <[email protected]>

Merge branch 'master' into raise-to-throw

b29c903

update Stdlib_Bool and Stdlib_Char

518bb75

remove comment

a36b71d

cknitt approved these changes Mar 25, 2025

View reviewed changes

cknitt merged commit 6654cb2 into rescript-lang:master Mar 25, 2025
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `throw` #7346

Add `throw` #7346

aspeddro commented Mar 17, 2025

aspeddro Mar 17, 2025

tsnobip Mar 17, 2025

aspeddro Mar 20, 2025

tsnobip left a comment

tsnobip Mar 17, 2025

aspeddro Mar 17, 2025

aspeddro Mar 19, 2025

aspeddro commented Mar 17, 2025

cknitt Mar 19, 2025

aspeddro Mar 19, 2025

aspeddro Mar 19, 2025

cknitt Mar 21, 2025

aspeddro Mar 21, 2025

aspeddro commented Mar 20, 2025

cknitt commented Mar 21, 2025

aspeddro commented Mar 21, 2025

fhammerschmidt commented Mar 21, 2025

cristianoc commented Mar 21, 2025

cknitt Mar 23, 2025

aspeddro Mar 24, 2025

		@@ -1,5 +1,6 @@
		/* Exceptions */
		external raise: exn => 'a = "%raise"

Add throw #7346

Add throw #7346

Conversation

aspeddro commented Mar 17, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsnobip left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aspeddro commented Mar 17, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aspeddro commented Mar 20, 2025

cknitt commented Mar 21, 2025

aspeddro commented Mar 21, 2025

fhammerschmidt commented Mar 21, 2025

cristianoc commented Mar 21, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Add `throw` #7346

Add `throw` #7346