Skip to content

Fix parse error on doc comment before "and" in type def #7001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 1, 2024

Fixes #6844

@cknitt cknitt assigned cristianoc and unassigned cristianoc Sep 1, 2024
@cknitt cknitt requested review from zth and cristianoc September 2, 2024 07:38
@cknitt cknitt merged commit b0b5fb1 into master Sep 2, 2024
20 checks passed
@cknitt cknitt deleted the fix-doc-comment branch September 2, 2024 08:51
cknitt added a commit to cknitt/rescript that referenced this pull request Sep 8, 2024
…g#7001)

* Fix parse error on doc comment before "and" in type def

* CHANGELOG
# Conflicts:
#	jscomp/syntax/src/res_core.ml
cknitt added a commit that referenced this pull request Sep 10, 2024
* Fix parse error on doc comment before "and" in type def

* CHANGELOG
# Conflicts:
#	jscomp/syntax/src/res_core.ml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add doc comment for a type definition using and
3 participants