Skip to content

Improve formatting of the generated JS code #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 4, 2024

Conversation

DZakh
Copy link
Member

@DZakh DZakh commented Aug 4, 2024

  • }\ncatch{ -> } catch {
  • for(let i = 0 ,i_finish = r.length; i < i_finish; ++i){ -> for (let i = 0, i_finish = r.length; i < i_finish; ++i) {
  • while(true) { -> while (true) {
  • Fixed tabulation for switch case bodies
  • Fixed tabulation for throw new Error bodies
  • Removed empty line at the end of switch statement
  • Removed empty default case from switch statement in the generated code

@DZakh
Copy link
Member Author

DZakh commented Aug 4, 2024

@cknitt It's ready for review

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot! 👍

@cknitt cknitt requested a review from cristianoc August 4, 2024 08:39
@cknitt cknitt merged commit 19a71b9 into rescript-lang:master Aug 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants