Cleanup: convert caml_format and js_math to .res.

[cristianoc]

No description provided.

[cknitt]

Great to have this converted to .res!

But GitHub recognizes the caml_format.res as binary. Maybe because of this?

  if (c >= 'A' && c <= 'Z') || ((c >= 'À' && c <= 'Ö') || c >= 'Ø' && c <= 'Þ') {

?

The original OCaml code had

let lowercase (c : char) : char =
  if (c >= 'A' && c <= 'Z')
  || (c >= '\192' && c <= '\214')
  || (c >= '\216' && c <= '\222')
  then Caml_char.unsafe_chr(Caml_char.code c + 32)
  else c

There is also this line in OCaml

  let c = if i < len then s.!(i) else '\000' in

Can't we use escape sequences in the ReScript code, too?

[cristianoc]

Great to have this converted to .res!

But GitHub recognizes the caml_format.res as binary. Maybe because of this?

  if (c >= 'A' && c <= 'Z') || ((c >= 'À' && c <= 'Ö') || c >= 'Ø' && c <= 'Þ') {

?

The original OCaml code had

let lowercase (c : char) : char =
  if (c >= 'A' && c <= 'Z')
  || (c >= '\192' && c <= '\214')
  || (c >= '\216' && c <= '\222')
  then Caml_char.unsafe_chr(Caml_char.code c + 32)
  else c

There is also this line in OCaml

  let c = if i < len then s.!(i) else '\000' in

Can't we use escape sequences in the ReScript code, too?

Thanks. Should be OK now.

[cknitt]

The reason I didn't convert js_math.res before was that it caused this change in release.ninja that I couldn't explain.

The dependency of belt_Array on js_math is gone now.
This might cause problems depending on the compilation order.

[cristianoc]

Perhaps we can remove the dependency:

@val @scope("Math") external random : unit => float = "random"
@val @scope("Math") external floor : float => int = "floor"
external toFloat: int => float = "%floatofint"

let shuffleInPlace = xs => {
  let len = length(xs)
  let random_int = (min, max) => floor(random() *. toFloat(max - min)) + min
  for i in 0 to len - 1 {
    swapUnsafe(xs, i, random_int(i, len)) /* [i,len) */
  }
}

[cristianoc]

Dependency removed now.

[cristianoc]

@cknitt this should be good to go, unless there are other potential issues.