Prioritizing --help arg handling
#6667
Conversation
It should, but didn't maybe we just need to avoid to use spawnSync in tests |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
cometkim
force-pushed
the
fix-help-with-args
branch
2 times, most recently
from
6d3f8f9 to
709d202
Compare
cometkim
force-pushed
the
fix-help-with-args
branch
from
709d202 to
6098902
Compare
cometkim
force-pushed
the
fix-help-with-args
branch
from
acd2ca7 to
321013c
Compare
cometkim
force-pushed
the
fix-help-with-args
branch
from
7abc713 to
09f6741
Compare
cometkim
force-pushed
the
fix-help-with-args
branch
from
4d37a0f to
e4134be
Compare
cometkim
force-pushed
the
fix-help-with-args
branch
from
e4134be to
3d47b87
Compare
This reverts commit e4069e1.
cometkim
force-pushed
the
fix-help-with-args
branch
from
accc231 to
f3bbcb7
Compare
| SIGTERM: 15, | ||
| }; | ||
|
|
||
| /** |
There was a problem hiding this comment.
It would be great if you could add a comment here explaining why we need this function instead of spawnSync / what issue it fixes.
There was a problem hiding this comment.
It is an asynchronous version of spawnSync, with no special behavior. But preferred than spawnSync because spawnSync is unstable for unknown reason.
I think it would be better to add some explanation onto execReScript util you suggested.
| async function test() { | ||
| { | ||
| // Shows build help with --help arg | ||
| const out = await exec(`../../../rescript`, ["build", "--help"], { |
There was a problem hiding this comment.
If we are already refactoring this, we could add a helper function in this file so that we can just write
const out = await execReScript(["build", "--help"]);There was a problem hiding this comment.
Can I separate it into a separate pure refactor PR?
Aside from the cli_help test, there are many other places to change.
|
I'll take a look during the day |
* backport bundle stdlib JS files for playground (#7255) * replace deprecated pipes with shlex * update setup-ocaml * use node 18 * add rollup linux as an optional dependency * use ubuntu-24.04 and ubuntu-24.04-arm * backport fix for hanging tests (#6667) * update artifacts.txt * backport: CI: don't run npm pack twice (#6923) * CI: don't run npm pack twice * Add typedefs for PackOutput * Update comments * update artifacts * Fix CHANGELOG.md --------- Co-authored-by: Christoph Knittel <[email protected]>
cc @DZakh
This also indirectly fixes the indeterministic build timeout on the master branch