Skip to content

Improve error message for missing label(s) in function application #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jan 18, 2024

No description provided.

@cknitt cknitt requested review from zth and cristianoc January 18, 2024 12:34
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, very nice! Been thinking about this one myself. Could you add a test fixture perhaps that captures the new error?

@cknitt cknitt force-pushed the improve-error-message branch from 484eb7d to 8c27920 Compare January 20, 2024 07:06
@cknitt cknitt requested a review from zth January 20, 2024 07:16
@cknitt cknitt merged commit 3151d66 into rescript-lang:11.0_release Jan 20, 2024
@cknitt cknitt deleted the improve-error-message branch January 20, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants