Special case uncurried fun with 1 arg of unit type #6131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cknitt would you test that this works? I'd need to check certain aspects of the implementation but first I'd like to be sure it works. |
cknitt
reviewed
Apr 11, 2023
cknitt
changed the title
Instead of removing the arguments on the lambda layer, pass the information down via the lambda layer using the additional field oneUnitArg. When this reaches the Lam layer with ocaml_fun in Lam_compile, only then remove the param. This ensures the code emitted is the same, except for the parameter.
|
@cknitt check again |
cknitt
approved these changes
Apr 12, 2023
|
Works great now, but as discussed it only applies to explicit uncurrying / uncurried mode, not to the So we still have a breaking change in v11 regarding |
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special case generation of uncurried functions with 1 argument of unit type so they don't take a parameter.