Emit tags as strings.

[cristianoc]

Emit tags as strings.
Currently does not have support for @deriving(jsConverter) and the relevant tests have been removed.

[jacobp100]

Will there be a way to turn this off and go back to the old behaviour?

[cristianoc]

No

[jacobp100]

Some engines struggle with switching over a large amount of strings (hermes). Recently, React removed a few instances of these big string switch cases for that reason

It'd be a shame if there was no escape hatch when you know you have performance critical code

[cristianoc]

Please send your perf measurements.

[jacobp100]

I’ll write myself a note to do that after upgrading

[FreddieGilbraith]

@jacobp100, looks like you can use the @as tag as an escape hatch:

@tag("state")
type loadingState = | @as(1) Loading({ready: bool}) | @as(2) Error({message: string}) | @as(3) Done({data: bool})

let state = Error({message: "Something went wrong!"})

https://rescript-lang.org/try?version=v11.0.1&code=AIFwhg5gFARAzuEBTGBKAUCAngByQAgBsB7MAEwEsA7CAZUQIF58AffYMOKARlXwBlSlGlADeAJyTksALnwAjYsUIBfPmw5cATHwCi48cXFiAtkjhxISOQnHUIa1u05QAzHwAixKkjFkw4HKKymro6IRIIPgIAUz4+obGomYWVnIwtMRmIAAW9vgA7khUUQWGNACEMKFAA

[czabaj]

Correct, use tagged variants, e.g. in my case, I needed interop with TypeScript enum and this chapter in the blog post goes to the point.

I then used coercion instead of the methods generated by @deriving(jsConverter)

The only drawback is that the conversion from JS -> Variant is missing, you cannot coerce e.g. int :> myType so you have to write the ...fromJs part yourself.