Fix dropping attributes of props in JSX v4

[mununki]

This PR fixes dropping the attributes from the arguments and core_type in the make function or make primitive in JSX v4.
It can fix issue #5904 either.

[mununki]

@cknitt IMHO, if this PR gets approval, then it needs to go to 10.1_release in the syntax repo too.
Sorry for making fixes for 10.1_release 😓

[cknitt]

@mununki No problem for me. 😄 Thanks for all the great work you are doing!
I agree, it would be good to have this backported to 10.1, too.

[mununki]

@cristianoc I realized that it doesn't have the same output as this fix in the syntax repo. Because the PR rescript-lang/syntax#683 was not merged in the syntax repo, parsing attributes in the argument of function works differently between compiler and syntax.

Maybe can we reopen the PR rescript-lang/syntax#683 and merge it in the syntax repo first, then make another PR for this fix?

[cristianoc]

@cristianoc I realized that it doesn't have the same output as this fix in the syntax repo. Because the PR rescript-lang/syntax#683 was not merged in the syntax repo, parsing attributes in the argument of function works differently between compiler and syntax.

Maybe can we reopen the PR rescript-lang/syntax#683 and merge it in the syntax repo first, then make another PR for this fix?

Oh that's right.
To be on the safe side, it might be best to take the PR from the compile repo, and apply it to the syntax repo. To make sure the changes are the same. Hopefully things have not diverged too much, and it's not too risky to do this in terms of introducing possible regressions.

[mununki]

To be on the safe side, it might be best to take the PR from the compile repo, and apply it to the syntax repo.

Not sure I understand correctly.
I think the original PR #5783 in the compiler had commits for different paths /res_syntax/**. Therefore I extracted diffs from each file, and apply them to /syntax/** in the syntax repo. rescript-lang/syntax#722

[mununki]

Backported to the syntax repo rescript-lang/syntax#723

[cristianoc]

The breaking change line on the changelog should go on branch 10.1 too.

[mununki]

The breaking change line on the changelog should go on branch 10.1 too.

Got it, thanks! 446c18a

[cristianoc]

The breaking change line on the changelog should go on branch 10.1 too.

Got it, thanks! 446c18a

Sorry the changelog in this PR was OK.
What I meant is, in the 10.1 branch this line is missing in the changelog.

[mununki]

Sorry the changelog in this PR was OK. What I meant is, in the 10.1 branch this line is missing in the changelog.

Oops, I misread your comment. I'll revert the changelog in this PR. I'll add the same line into the changelog in the 10.1_release branch.'ll

[cristianoc]

I think this is ready to merge when CI is done.