Skip to content

Dce touchups #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Dce touchups #366

merged 2 commits into from
Mar 9, 2022

Conversation

zth
Copy link
Collaborator

@zth zth commented Mar 8, 2022

  • Expose the "Stop dead code analysis" command to the user so it can be run via the command palette. We already have the start command exposed, so I think it makes sense to expose the stop command as well, in addition to the stop button in the status bar.
  • Do not mark "redundant optional argument" warnings as dead/unused code, since it's not really. Closes Dead code analysis - all warnings are marked as dead code #362

@cristianoc
Copy link
Collaborator

Thanks!

@cristianoc cristianoc merged commit 34cc758 into rescript-lang:master Mar 9, 2022
@zth zth deleted the dce-touchups branch March 9, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead code analysis - all warnings are marked as dead code
2 participants