Skip to content

Add partition_id to ChunkBatch #9993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Add partition_id to ChunkBatch #9993

merged 1 commit into from
May 19, 2025

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented May 19, 2025

Related

What

In the future, we have decided that each chunk should know its partition id, here is a first step into that direction (right now we use ad-hoc code in the dataplatform for this).

The only thing unclear to me is how that will work with blueprints in the future.

@grtlr grtlr requested a review from emilk May 19, 2025 09:29
@grtlr grtlr added the exclude from changelog PRs with this won't show up in CHANGELOG.md label May 19, 2025
Copy link

github-actions bot commented May 19, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
2043d40 https://rerun.io/viewer/pr/9993 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr grtlr mentioned this pull request May 19, 2025
@grtlr
Copy link
Contributor Author

grtlr commented May 19, 2025

Might also be superseded by #9991.

@grtlr grtlr merged commit 8d3ad7f into main May 19, 2025
41 checks passed
@grtlr grtlr deleted the grtlr/partition-id-sorbet-chunk branch May 19, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants