Skip to content

Fix building with arrow 20.0.0 #9966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

adamreeve
Copy link
Contributor

Related

Fixes #9864

What

Fixes compatibility with Arrow 20, which made the constructor of arrow::PrimitiveArray protected due to its use from user code resulting in invalid arrays.

I've tested building the rerun-sdk port in vcpkg at version 0.22.1 with this patch applied and Arrow upgraded to 20.0.0.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for opening this pull request.

Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.

@Wumpf Wumpf added 🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🌊 C++ API C/C++ API specific include in changelog labels May 14, 2025
@Wumpf Wumpf added this to the 0.23.3 (?) milestone May 14, 2025
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for looking after this!

Would be great if we could test this on ci, but not entirely straight forward how to install different arrow versions there (I'd like to keep testing the older one for a bit longer). So let's skip that for now

@Wumpf Wumpf merged commit d620a64 into rerun-io:main May 14, 2025
13 of 14 checks passed
@adamreeve adamreeve deleted the arrow-20-compat branch May 14, 2025 08:38
BillyONeal added a commit to assignUser/vcpkg that referenced this pull request May 14, 2025
jprochazk pushed a commit that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🌊 C++ API C/C++ API specific 💣 crash crash, deadlock/freeze, do-no-start include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure with libarrow 20.0
2 participants