Skip to content

Avoid WebGPU on Safari #9952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Avoid WebGPU on Safari #9952

merged 1 commit into from
May 12, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented May 11, 2025

@emilk emilk requested a review from Wumpf May 11, 2025 21:14
@emilk emilk added 🕸️ web regarding running the viewer in a browser exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 11, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 11, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ f9da4f4 https://rerun.io/viewer/pr/9952 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk changed the title Only use WebGL on Safari Avoid WebGPU on Safari May 12, 2025
Wumpf
Wumpf approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this gives me some peace of mind!

@Wumpf Wumpf merged commit fa1717e into main May 12, 2025
43 checks passed
@Wumpf Wumpf deleted the emilk/no-webgpu-on-safari branch May 12, 2025 15:35
grtlr pushed a commit that referenced this pull request May 13, 2025
@emilk @grtlr
Avoid WebGPU on Safari (#9952)
cdb1025
@emilk emilk added this to the 0.23.3 (?) milestone May 15, 2025
jprochazk pushed a commit that referenced this pull request May 24, 2025
@emilk @jprochazk
Avoid WebGPU on Safari (#9952)
b4f7f94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
0.23.3
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @Wumpf