Skip to content

Add ColumnDescriptor::RowId #9919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2025
Merged

Add ColumnDescriptor::RowId #9919

merged 9 commits into from
May 8, 2025

Conversation

@emilk emilk added include in changelog 🔩 data model Sorbet feat-dataframe-view Everything related to the dataframe view feat-dataframe-api Everything related to the dataframe API labels May 8, 2025
@emilk emilk force-pushed the emilk/row-id-col-descr branch from 2ae4cf1 to 8558790 Compare May 8, 2025 12:37
Copy link

github-actions bot commented May 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
f0ff3df https://rerun.io/viewer/pr/9919 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk changed the title Support RowId in dataframe code and UI Add ColiumnDescriptor::RowId May 8, 2025
@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md and removed include in changelog labels May 8, 2025
@emilk emilk force-pushed the emilk/row-id-col-descr branch from 8558790 to ecd85f7 Compare May 8, 2025 13:43
@emilk emilk marked this pull request as ready for review May 8, 2025 13:43
@abey79 abey79 changed the title Add ColiumnDescriptor::RowId Add ColumnDescriptor::RowId May 8, 2025
@emilk
Copy link
Member Author

emilk commented May 8, 2025

@rerun-bot full-check

Copy link

github-actions bot commented May 8, 2025

@emilk
Copy link
Member Author

emilk commented May 8, 2025

Some test failures is because of flakyness fixed in #9912

@emilk
Copy link
Member Author

emilk commented May 8, 2025

@rerun-bot full-check

Copy link

github-actions bot commented May 8, 2025

@emilk
Copy link
Member Author

emilk commented May 8, 2025

@rerun-bot full-check

Copy link

github-actions bot commented May 8, 2025

@emilk emilk force-pushed the emilk/row-id-col-descr branch from 2f8db13 to f0ff3df Compare May 8, 2025 15:18
@emilk
Copy link
Member Author

emilk commented May 8, 2025

@rerun-bot full-check

Copy link

github-actions bot commented May 8, 2025

@emilk emilk merged commit 30da9b9 into main May 8, 2025
75 checks passed
@emilk emilk deleted the emilk/row-id-col-descr branch May 8, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model Sorbet exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API feat-dataframe-view Everything related to the dataframe view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for RowIdColumnDescriptor to re_sorbet::ColumnDescriptor
2 participants