Skip to content

Fix size check for NV12 & YUY2 formats in C++ and Rust #9890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 6, 2025

Related

What

NV12 & YUY2 each reported the wrong bytes size in C++ and Python, causing checks on log/serialization to fail incorrectly.

@Wumpf Wumpf added 🪳 bug Something isn't working 🐍 Python API Python logging API 🦀 Rust API Rust logging API labels May 6, 2025
@Wumpf Wumpf added this to the 0.23.2 milestone May 6, 2025
@Wumpf Wumpf changed the title Fix num_bytes check for NV12 & YUY2 formats in C++ and Rust Fix size check for NV12 & YUY2 formats in C++ and Rust May 6, 2025
Copy link

github-actions bot commented May 6, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
485fc0d https://rerun.io/viewer/pr/9890 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf merged commit 165ae52 into main May 6, 2025
47 of 52 checks passed
@Wumpf Wumpf deleted the andreas/fix-nv12-cpp-rust branch May 6, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NV12 format, number of bytes should be 1.5x of pixel count, instead of 2
2 participants