Skip to content

Fix world grid not scaling correctly when camera is below the grid #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Fix world grid not scaling correctly when camera is below the grid #9867

merged 1 commit into from
May 2, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 2, 2025

@Wumpf Wumpf added 🪳 bug Something isn't working 🔺 re_renderer rendering, graphics, GPU 📺 re_viewer affects re_viewer itself labels May 2, 2025
@Wumpf Wumpf added this to the 0.23.2 milestone May 2, 2025
abey79
abey79 approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it was foretold :)

@abey79 abey79 merged commit 80b588c into main May 2, 2025
38 of 42 checks passed
@abey79 abey79 deleted the andreas/fix-grid-scaling-when-below-grid branch May 2, 2025 11:20
abey79 pushed a commit that referenced this pull request May 2, 2025
@Wumpf @abey79
Fix world grid not scaling correctly when camera is below the grid (#…
32beb56 
…9867)

### Related

* Fixes #9866


### What

Before:

![image](https://github.com/user-attachments/assets/f4149e74-0dc9-4afb-ab79-ddb071167a51)


After:

![image](https://github.com/user-attachments/assets/7705758e-73ed-4476-a19f-a4338eef03e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog 🔺 re_renderer rendering, graphics, GPU 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.23.2
Development

Successfully merging this pull request may close these issues.

Auto major/minor grid scaling of the ground plane does not work when seen from below
2 participants
@Wumpf @abey79