Skip to content

Move *Selector from re_chunk_store to re_sorbet #9851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Move *Selector from re_chunk_store to re_sorbet #9851

merged 1 commit into from
Apr 30, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Apr 30, 2025

Related

What

Move {Column|ComponentColumn|TimelineColumn}Selector to re_sorbet where they belong (alongside the *Descriptor crowd).

@abey79 abey79 added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 6559281 https://rerun.io/viewer/pr/9851 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 merged commit b383dba into main Apr 30, 2025
42 checks passed
@abey79 abey79 deleted the antoine/selector-refactor branch April 30, 2025 14:47
abey79 added a commit that referenced this pull request May 1, 2025
@abey79
Move *Selector from re_chunk_store to re_sorbet (#9851)
ff91a21 
### Related

* Part of #9837

### What

Move `{Column|ComponentColumn|TimelineColumn}Selector` to `re_sorbet`
where they belong (alongside the `*Descriptor` crowd).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @jleibs