Improve and mitigate warnings around dataloss when flushing #9846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grtlr
changed the title
grtlr
added
include in changelog
🪵 Log & send APIs
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
pushed a commit
that referenced
this pull request
May 2, 2025
### Related * Closes #9818. ### What > [!IMPORTANT] > This PR also changes the way `RecordingStream` is free'd in the C/C++ API. Before we called `stream.disconnect`, which unnecessarily replaced the current sink with a _buffered_ sink that would be immediately dropped afterwards. Not only did this cause spam in the log outputs, it also lead to race conditions upon (log) application shutdown. This PR makes it more explicit why we drop data during flushing, by bumping the log messages to `warn!`. It also improves the message by pointing the users to `flush_timeout`. We also bump the default timeout from two seconds to now 3 seconds. It's worth taking note that explicitly calling `flush_blocking` from our SDKs should be able to opt-out of this timeout, to ensure all data is sent. This will be tracked here: * #9845.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Important
This PR also changes the way
RecordingStreamis free'd in the C/C++ API. Before we calledstream.disconnect, which unnecessarily replaced the current sink with a buffered sink that would be immediately dropped afterwards. Not only did this cause spam in the log outputs, it also lead to race conditions upon (log) application shutdown.This PR makes it more explicit why we drop data during flushing, by bumping the log messages to
warn!. It also improves the message by pointing the users toflush_timeout.We also bump the default timeout from two seconds to now 3 seconds.
It's worth taking note that explicitly calling
flush_blockingfrom our SDKs should be able to opt-out of this timeout, to ensure all data is sent. This will be tracked here:flush_blockingto make flush timeout optional #9845.