Skip to content

Add support for /entry/$ENTRY_ID URIs #9542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 8, 2025
Merged

Add support for /entry/$ENTRY_ID URIs #9542

merged 6 commits into from
Apr 8, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Apr 8, 2025

Related

What

Add support for "entry" uris, in the form of:

$SERVER/entry/$ENTRY_ID

When opened by the viewer, the corresponding server is added (if needed) and the entry is selected.

TODO:

  • test opening links within rerun
  • test opening links from notebook

@abey79 abey79 added exclude from changelog PRs with this won't show up in CHANGELOG.md dataplatform Rerun Data Platform integration labels Apr 8, 2025
Copy link

github-actions bot commented Apr 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
286b511 https://rerun.io/viewer/pr/9542 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Apr 8, 2025

Latest documentation preview deployed successfully.

Result Commit Link
286b511 https://landing-5m5rz5cqu-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@abey79
Copy link
Member Author

abey79 commented Apr 8, 2025

tested with :

import rerun as rr

rr.init("rerun_example_any_values", spawn=True)

rr.log(
    "any_values",
    rr.AnyValues(
        redap_url="rerun+http://localhost:51234",
        redap_entry_url="rerun+http://localhost:51234/entry/18344CFCB4A74EF664f155c1fbf04e83",
        redap_partition_url="rerun+http://localhost:51234/dataset/18344CFCB4A74EF664f155c1fbf04e83?partition_id=ILIAD_7ae1bcff_2023_06_04_17h_55m_44s",
    ),
)

Comment on lines +47 to +49
if file_path.endswith(".rs"):
continue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill split up app.rs and revert this in a follow-up pr

@abey79 abey79 merged commit 5057a14 into main Apr 8, 2025
42 checks passed
@abey79 abey79 deleted the antoine/entry-uri branch April 8, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants