Skip to content

Add experimental send_table to Python SDK #9538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 9, 2025
Merged

Add experimental send_table to Python SDK #9538

merged 8 commits into from
Apr 9, 2025

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Apr 8, 2025 •
edited
Loading

Related

What

This adds minimal support for send_table to re_grpc_client and implements a new experimental API in the Python SDK:

client = ViewerClient(addr="rerun+http://0.0.0.0:9876")
client.send_table(
    "Hello from Python",
    pa.RecordBatch.from_pydict({
        "id": [1, 2, 3],
        "url": ["https://www.rerun.io", "https://github.com/rerun-io/rerun", "https://crates.io/crates/rerun"],
    }),
)

Testing

Either via the snippet:

pixi run py-build
pixi run -e py python docs/snippets/all/howto/send_table.py

Or via the notebook that was updated in this PR.

@grtlr grtlr added include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Apr 8, 2025
@grtlr grtlr requested a review from abey79 April 8, 2025 09:46
@grtlr grtlr mentioned this pull request Apr 8, 2025
Closed
6 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 84871e1 https://rerun.io/viewer/pr/9538 +nightly +main

Note: This comment is updated whenever you push a commit.

abey79
abey79 approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice and straighforward!

rerun_py/src/viewer.rs Outdated
/// table-related operations, most importantly `WriteTable`.
// TODO(grtlr): In the future, we probably want to merge this with the other APIs.
#[derive(Clone)]
pub struct TableConnectionHandle {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't ViewerConnectionHandle be a better name here?

docs/snippets/all/howto/send_table.py Outdated
Copy link
Member

@abey79 abey79 Apr 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to cover this feature in the docs. Can you please open an issue and tag it with the 0.23 milestone?

crates/store/re_grpc_client/src/message_proxy/write_table.rs Outdated
pub type TableClient = MessageProxyServiceClient<tonic::transport::Channel>;

#[cfg(not(target_arch = "wasm32"))]
pub async fn table_client(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, viewer_client?

@grtlr grtlr merged commit efe29aa into main Apr 9, 2025
37 checks passed
@grtlr grtlr deleted the grtlr/send-table-python-sdk branch April 9, 2025 08:48
@emilk emilk mentioned this pull request Apr 10, 2025
Merged
emilk added a commit that referenced this pull request Apr 10, 2025
@emilk
Exclude how_to/send_table from snippets (#9562)
a46865a 
* Follow-up to #9538
@emilk emilk mentioned this pull request Apr 11, 2025
Closed
16 tasks
@grtlr grtlr mentioned this pull request Apr 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port send_dataframe to Rust and improve usability Proper viewer support for dataframes
2 participants
@grtlr @abey79