Implement send_table in re_grpc_server and re_viewer
#9510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
grtlr
force-pushed
the
grtlr/send-table-grpc-server
branch
from
aacec47 to
95f6c7c
Compare
grtlr
changed the title
re_grpc_serverre_grpc_server and re_viewer preparation for send_table
grtlr
added
📺 re_viewer
emilk
reviewed
Apr 7, 2025
emilk
reviewed
Apr 7, 2025
emilk
reviewed
Apr 7, 2025
| @@ -171,6 +171,8 @@ struct PendingFilePromise { | |||
| promise: poll_promise::Promise<Vec<re_data_source::FileContents>>, | |||
| } | |||
|
|
|||
| type ReceiveSetTable = parking_lot::Mutex<Vec<crossbeam::channel::Receiver<TableMsg>>>; | |||
There was a problem hiding this comment.
ReceiveSetTable reads weird to me
Suggested change
| type ReceiveSetTable = parking_lot::Mutex<Vec<crossbeam::channel::Receiver<TableMsg>>>; | |
| type TableReceiverSet = parking_lot::Mutex<Vec<crossbeam::channel::Receiver<TableMsg>>>; |
There was a problem hiding this comment.
I named it this way to make it somewhat symmetric with ReceiveSet<LogMsg>.
emilk
reviewed
Apr 7, 2025
grtlr
changed the title
re_grpc_server and re_viewer preparation for send_tablesend_table in re_grpc_server and re_viewer
And actually do that.
emilk
approved these changes
Apr 7, 2025
Co-authored-by: Emil Ernerfeldt <[email protected]>
Wumpf
added
🪵 Log & send APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
ViewerClient::send_tablemethod to SDK #9456What
The server-side and viewer logic for
send_table. Also contains, the required changes for the notebook.