Improve rerun.notebook.Viewer
constructor
#9495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now, the
use_global_recording
param ofrr.notebook.Viewer
didn't actually do as advertised. Setting it toFalse
would make theViewer
constructor ignore (almost) all other parameters.The original intent for that parameter was to allow creating a completely empty Viewer. The new behavior is:
use_global_recording
defaults toFalse
if aurl
is provided.use_global_recording
defaults toTrue
otherwise.use_global_recording
isTrue
, then we useget_data_recording
to pick up either the thread-local or global recording.This means it is now possible to create a completely empty Viewer, and that is the default behavior given no params, and no global recording:
If a
url
is provided, then by default we only show thaturl
:Using both a
url
and either an explicit/globalrecording
is still possible:If no
url
is provided, we pick up the global recording by default, but it can be turned off: