Skip to content

Show tables under local and use table icon #9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Show tables under local and use table icon #9486

merged 1 commit into from
Apr 4, 2025

Conversation

lucasmerlin
Copy link
Contributor

What

  • Rename "Local recordings" to just "Local"
  • in the design it was "Local storage", but I think that is a bit confusing since for now they aren't stored, if you close the viewer it's gone
  • Also uses new table icon

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 55a86c6 https://rerun.io/viewer/pr/9486 +nightly +main

Note: This comment is updated whenever you push a commit.

@lucasmerlin lucasmerlin added ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 4, 2025
grtlr
grtlr approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@grtlr grtlr merged commit 6e2f210 into main Apr 4, 2025
40 of 41 checks passed
@grtlr grtlr deleted the lucas/show-tables-under-local branch April 4, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmerlin @grtlr