Update cpp/eigen_opencv README snippets #9463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaced snippet using `rerun::TensorBuffer::u8` with `rerun::borrow` * Changed `reinterpret_cast` snippet to use an existing constructor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
abey79
added
📖 documentation
Wumpf
approved these changes
Apr 3, 2025
Sorry, I thought that's what you meant by "patching this upstream". |
|
It looks like the stereo_vision_slam example is also out-of-date, but it is still a reflection of what is in the StereoVision-SLAM source, so I left it alone. |
|
Yeah we realtively rarely update the out-of-repo examples, we don't have the capacity to keep them all up to date. Let's leave it be 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rerun::TensorBuffer::u8withrerun::borrowreinterpret_castsnippet to use an existing constructorRelated
Closes #9459
What
Brings snippets in the README up-to-date with the current API for the cpp/eigen_opencv example.