Add TableStore for table/dataframe entries + basic UI
#9437
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
grtlr
changed the title
StoreHubTableStore for table/dataframe entries + basic UI
grtlr
added
ui
| ui.ctx().screen_rect().width(), | ||
| )); | ||
|
|
||
| left_panel.show_animated_inside( |
There was a problem hiding this comment.
lotsa cruft in this and it's clearly meant to closely mimick the code below doing the same thing. We can't move that out into a function and re-use?
There was a problem hiding this comment.
Yeah that would be nice, but that function would need many parameters, and that part of the code will probably change again anyways soon.
I left a TODO to help with discoverability.
| // TODO: This has no business in `StoreHub` because it is an UI implementation detail | ||
| fn _find_closest_recording(&self, id: &StoreId) -> Option<StoreId> { |
There was a problem hiding this comment.
and looks like it's no longer used anywhere, so just remove?
There was a problem hiding this comment.
This is not used right now, because I commented out the relevant code. I should sync with @lucasmerlin, he probably has ideas on how to handle finding the next entry in the updated "cataloged" recording panel.
There was a problem hiding this comment.
Will remove, created follow up issue: #9464
Related
send_dataframeshould generate a an index column #8593What
This brings a very basic table entry to the Rerun viewer. Tables are essentially dataframes, can contain Rerun-native components, but don't have to adhere to some of the restrictions that we place on regular entities (i.e. we don't require indexation columns).
Testing
The following will create a very basic table in-memory. A follow-up PR will add GRPC-based sending of dataframes.
Known issues