Skip to content

Rename Scalars::one to Scalars::single #9436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Rename Scalars::one to Scalars::single #9436

merged 2 commits into from
Mar 31, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 31, 2025

@emilk
Rename Scalars::one to Scalars::single
0a590dc 
`one` can be confused for `1.0`
@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 31, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 750bce6 https://rerun.io/viewer/pr/9436 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf self-requested a review March 31, 2025 15:43
Wumpf
Wumpf approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emilk emilk merged commit f55e447 into main Mar 31, 2025
36 checks passed
@emilk emilk deleted the emilk/rename-one-to-single branch March 31, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @Wumpf