Python/CI: Raise exception on warning, e.g. call of @deprecated #9384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🐍 Python API
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
changed the title
timsaucer
approved these changes
Mar 26, 2025
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14083097381 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14083660608 |
7 tasks
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14085081269 |
emilk
added a commit
that referenced
this pull request
Mar 27, 2025
…s`/`SeriesPoints`/`Scalars` (#9338) ### Related * Fixes #9022 ### What * `SeriesLine` -> `SeriesLines` * `SeriesPoint` -> `SeriesPoints` * `Scalar` -> `Scalars` The old types are still around, just deprecated. ~There's a unit test ensuring that they still work just the same (visualizers will still activate automatically!)~ **EDIT** by @emilk: the old types are migrated (renamed) during loading by `re_sorbet`! The change is fairly straight forward in Python & C++. In Rust there's some ergonomic loss since arrays need to be passed more often now - in particular annoying on `Scalars` for single scalars. For convenience @emilk added a `Scalar::one` constructor for Rust. On the flip side it's much nicer now to create columns of `Scalars` since `with_many_scalar` is no longer a thing, instead you can just create `Scalar(..)` with an array. --- * [x] migration guide * [x] describe what's going on here * [x] Merge #9384 * [x] Update references to deprecated archetypes from doclinks in fbs files * [x] Remove all uses to the old archetypes * [x] Remove all references to the old names from everywhere (e.g. all docs) * [x] Full check --------- Co-authored-by: Emil Ernerfeldt <[email protected]> Co-authored-by: Jochen Görtler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
SeriesLine/SeriesPoint/Scalarin favor ofSeriesLines/SeriesPoints/Scalars#9338What
We do not want to call deprecated functions from our examples and snippets (it sets a bad example!).
Unfortunately there is nothing stopping us from doing so right now.
Until this PR.
With
PYTHONWARNINGS="error"any Pythonwarningresults in an exception, which should fail the example/snippet.TODO
@rerun-bot full-check