Skip to content

Implement basic UI to display recording properties #9381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Mar 26, 2025

Related

What

This crates a basic Properties section in the re_selection_panel to show the recording properties.

Important

The truncation in the screenshot below will be handled by:

image

Copy link

github-actions bot commented Mar 26, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
9aab4ee https://rerun.io/viewer/pr/9381 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr grtlr added this to the 0.23.0 milestone Mar 26, 2025
@grtlr grtlr marked this pull request as ready for review March 26, 2025 17:00
@grtlr grtlr added include in changelog ui concerns graphical user interface labels Mar 26, 2025
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly suggest to move properties to the selection panel instead of the EntityDb data ui.

grtlr pushed a commit that referenced this pull request Mar 27, 2025
…pe` (#9392)

### Related

* Fixes #9391
* Exposed by #9381

### What

The new property UI would call multiple `EntityPath::data_ui`
sequentially. These would lead to `component_list_ui` to be called, and
because they had a hard-coded id, there would be cross-talk between the
scopes' underlying egui memory storage. This PR makes the id unique.
@grtlr grtlr requested a review from abey79 March 27, 2025 08:52
@grtlr grtlr linked an issue Mar 27, 2025 that may be closed by this pull request
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@grtlr grtlr merged commit ad0aa52 into main Mar 27, 2025
36 checks passed
@grtlr grtlr deleted the grtlr/arbitrary-property-data-ui branch March 27, 2025 09:15
@emilk emilk mentioned this pull request Apr 11, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dedicated UI for recording properties
2 participants