-
Notifications
You must be signed in to change notification settings - Fork 482
Implement basic UI to display recording properties #9381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly suggest to move properties to the selection panel instead of the EntityDb
data ui.
…pe` (#9392) ### Related * Fixes #9391 * Exposed by #9381 ### What The new property UI would call multiple `EntityPath::data_ui` sequentially. These would lead to `component_list_ui` to be called, and because they had a hard-coded id, there would be cross-talk between the scopes' underlying egui memory storage. This PR makes the id unique.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Related
What
This crates a basic Properties section in the
re_selection_panel
to show the recording properties.Important
The truncation in the screenshot below will be handled by:
DataUi
forEntityDb
#9391