Group open recordings by origin, dataset/appid and examples #9377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
lucasmerlin
force-pushed
the
lucas/improve-local-remote-flow
branch
from
d20c6c7 to
b1d3cf2
Compare
lucasmerlin
added
ui
lucasmerlin
changed the title
abey79
approved these changes
Mar 26, 2025
Comment on lines
+315
to
+319
| if y_offset != 0.0 { | ||
| ui.add_space(y_offset); | ||
| height -= y_offset; | ||
| } | ||
|
|
There was a problem hiding this comment.
The result of this is the gap, visible eg here:
I wonder if things would not look better if we kept the original height for the highlight.
An alternative would be to not have full-width highlight for those titles, but some other kind of highlight (to suggest they are [sometime] clickable). I think i would prefer that, but then it becomes a design issue, so probably out of scope for this pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Groups items in the recordings panel by their dataset / locally by app id / examples. This doesn't touch the redap browser yet, I'll update that UI in a separate PR.
Screen.Recording.2025-03-26.at.12.14.34.mov