Skip to content

Use consistent time unit names for our API #9343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Mar 31, 2025
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 21, 2025

Related

What

We have been wildly inconsistent with how we name our time units, and it is time we fixed it. So starting now, we're using:

  • secs instead of s or seconds
  • nanos instead of ns or nanoseconds
  • millis instead of ms or milliseconds

All function and parameters using the old names have been deprecated, and will be removed in a future version.

Why these names?

Copy link

github-actions bot commented Mar 21, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
577cb94 https://rerun.io/viewer/pr/9343 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Mar 21, 2025

Latest documentation preview deployed successfully.

Result Commit Link
577cb94 https://landing-3cnfbjd8s-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf self-requested a review March 21, 2025 09:47
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@emilk
Copy link
Member Author

emilk commented Mar 21, 2025

@rerun-bot full-check

Copy link

@emilk emilk mentioned this pull request Mar 21, 2025
11 tasks
@emilk emilk requested a review from Wumpf March 25, 2025 09:37
@emilk
Copy link
Member Author

emilk commented Mar 25, 2025

@rerun-bot full-check

Copy link

@emilk
Copy link
Member Author

emilk commented Mar 26, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/14078243833

@emilk
Copy link
Member Author

emilk commented Mar 26, 2025

@rerun-bot full-check

Copy link

@emilk
Copy link
Member Author

emilk commented Mar 26, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/14083729098

@emilk emilk added 🐍 Python API Python logging API 🌊 C++ API C/C++ API specific labels Mar 27, 2025
@emilk emilk changed the title Use consistent time unit names for Rust API Use consistent time unit names for our API Mar 27, 2025
@emilk
Copy link
Member Author

emilk commented Mar 27, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/14109499697

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found two more incorrect renames, otherwise looking good now!

@emilk emilk merged commit 45415da into main Mar 31, 2025
42 checks passed
@emilk emilk deleted the emilk/consistent-naming branch March 31, 2025 15:42
@emilk emilk mentioned this pull request Apr 11, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific include in changelog 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a timeline type for relative time
2 participants