-
Notifications
You must be signed in to change notification settings - Fork 451
Use consistent time unit names for our API #9343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13991374628 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14065570698 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14078243833 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14083276887 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14083729098 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14109499697 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found two more incorrect renames, otherwise looking good now!
Related
What
We have been wildly inconsistent with how we name our time units, and it is time we fixed it. So starting now, we're using:
secs
instead ofs
orseconds
nanos
instead ofns
ornanoseconds
millis
instead ofms
ormilliseconds
All function and parameters using the old names have been deprecated, and will be removed in a future version.
Why these names?