Skip to content

Double clicking plots focuses them now in other panels #9333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 20, 2025

Double click on a time series (line or scatter) will now not reset the view but instead perform the viewer's "focus" action - this causes scroll-to in blueprint & streams panels.
Furthermore, since this is now relevant due to multi-scalar per entity, double click selects now the entire entity rather than an instance (similar to double clicking a point cloud point)

Screen.Recording.2025-03-20.at.15.33.38.mov

@Wumpf Wumpf added include in changelog 📈 plot Plots, charts, graphs, timeseries, … 📺 re_viewer affects re_viewer itself labels Mar 20, 2025
Copy link

github-actions bot commented Mar 20, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
009924f https://rerun.io/viewer/pr/9333 +nightly +main

Note: This comment is updated whenever you push a commit.

@jprochazk jprochazk self-requested a review March 20, 2025 11:51
@jprochazk
Copy link
Member

Is this the expected behavior? When I zoom out and double-click, it "expands" the plot to fit the zoom level. Resetting to default blueprint doesn't undo this. I don't know if this is the intended behavior, but it doesn't seem right

plots.mp4

@Wumpf
Copy link
Member Author

Wumpf commented Mar 20, 2025

Good catch, I clearly broke something there. It even shows in the video I posted on the PR, totally missed that 🤦

@Wumpf Wumpf marked this pull request as draft March 20, 2025 12:14
@Wumpf Wumpf force-pushed the andreas/focus-time-series branch from 69e3297 to df92b65 Compare March 20, 2025 14:34
@Wumpf
Copy link
Member Author

Wumpf commented Mar 20, 2025

fixed & updated description video

@Wumpf Wumpf marked this pull request as ready for review March 20, 2025 14:35
@jprochazk
Copy link
Member

jprochazk commented Mar 20, 2025

Am I supposed to be able to select a single instance (/point) of e.g. the scatter plot in the plots example? I can't seem to be able to do that. But that doesn't work on main either. Double-clicking seems to just do the same thing as single-click.

As for the zooming behavior, it seems to work now. There is still one hiccup, but not sure how actionable it is. If I zoom into the scatter plot, and double click without moving my mouse, the scatter plot stretches like in my original video. After moving my mouse, it goes back to normal. This may just be a missing request_redraw somewhere.

Tested in the web viewer, I have not tested the native viewer. Zooming out works well.

plots2.mp4

@jprochazk
Copy link
Member

Weirdly enough, the zoom-in into double-click issue is the exact same on main, but there it only happens for a single frame.

plots3.mp4

Copy link
Member

@jprochazk jprochazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM, not sure how immediately actionable the other stuff is.

@Wumpf
Copy link
Member Author

Wumpf commented Mar 20, 2025

Am I supposed to be able to select a single instance (/point) of e.g. the scatter plot in the plots example? I can't seem to be able to do that. But that doesn't work on main either.

Known issue, that's the same problem we have when clicking a point in a point cloud with time series ranges: selections aren't time line aware, causes all sort of annoyance.

Double-clicking seems to just do the same thing as single-click.

That shouldn't be the case though. Single click shouldn't perform the focus action. Regarding what is selected they are expected to be the same iff you have a single series. Which is everywhere the case except the bottom demo where both lines originate from the same entity.
So I thiiiiiiink we're talking about the same thing, but this highlights that stuff is kinda confusing :/

If I zoom into the scatter plot, and double click without moving my mouse, the scatter plot stretches like in my original video. After moving my mouse, it goes back to normal. This may just be a missing request_redraw somewhere.

Uhoh. Want to have a look at this, your assessment sounds about right. Thank you!

@Wumpf Wumpf added the do-not-merge Do not merge this PR label Mar 20, 2025
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Mar 21, 2025
@Wumpf
Copy link
Member Author

Wumpf commented Mar 21, 2025

fixed the delayed adjustment bug with another repaint. sucks a bit that that is needed, but this will do for now

@Wumpf Wumpf merged commit 8e42d5f into main Mar 21, 2025
38 of 39 checks passed
@Wumpf Wumpf deleted the andreas/focus-time-series branch March 21, 2025 09:53
@emilk emilk mentioned this pull request Apr 11, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 📈 plot Plots, charts, graphs, timeseries, … 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants