-
Notifications
You must be signed in to change notification settings - Fork 482
Double clicking plots focuses them now in other panels #9333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Is this the expected behavior? When I zoom out and double-click, it "expands" the plot to fit the zoom level. Resetting to default blueprint doesn't undo this. I don't know if this is the intended behavior, but it doesn't seem right plots.mp4 |
Good catch, I clearly broke something there. It even shows in the video I posted on the PR, totally missed that 🤦 |
69e3297
to
df92b65
Compare
fixed & updated description video |
Am I supposed to be able to select a single instance (/point) of e.g. the scatter plot in the plots example? I can't seem to be able to do that. But that doesn't work on As for the zooming behavior, it seems to work now. There is still one hiccup, but not sure how actionable it is. If I zoom into the scatter plot, and double click without moving my mouse, the scatter plot stretches like in my original video. After moving my mouse, it goes back to normal. This may just be a missing Tested in the web viewer, I have not tested the native viewer. Zooming out works well. plots2.mp4 |
Weirdly enough, the zoom-in into double-click issue is the exact same on plots3.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM, not sure how immediately actionable the other stuff is.
Known issue, that's the same problem we have when clicking a point in a point cloud with time series ranges: selections aren't time line aware, causes all sort of annoyance.
That shouldn't be the case though. Single click shouldn't perform the focus action. Regarding what is selected they are expected to be the same iff you have a single series. Which is everywhere the case except the bottom demo where both lines originate from the same entity.
Uhoh. Want to have a look at this, your assessment sounds about right. Thank you! |
fixed the delayed adjustment bug with another repaint. sucks a bit that that is needed, but this will do for now |
Double click on a time series (line or scatter) will now not reset the view but instead perform the viewer's "focus" action - this causes scroll-to in blueprint & streams panels.
Furthermore, since this is now relevant due to multi-scalar per entity, double click selects now the entire entity rather than an instance (similar to double clicking a point cloud point)
Screen.Recording.2025-03-20.at.15.33.38.mov