Fix the string representation of archetypes #9297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
🐍 Python API
jleibs
approved these changes
Mar 17, 2025
| else: | ||
| comp_contents = pformat(as_arrow_array().to_pylist(), compact=True) | ||
|
|
||
| yield f" {fld.name}={comp_contents}" |
There was a problem hiding this comment.
nit: 4 spaces here combined with the 1 space indentation from pformat feels odd to me.
I'd personally find something like this more legible:
rr.Points3D(
positions=[[11.0, 2.0, 3.0], [2.0, 3.0, 2.0], [3.0, 2.0, 3.0], [2.0, 3.0, 2.0],
[3.0, 2.0, 3.0], [2.0, 3.0, 2.0], [3.0, 2.0, 3.0], [2.0, 3.0, 2.0],
[3.0, 2.0, 3.0], [2.0, 3.0, 2.0], [3.0, 2.0, 3.0], [2.0, 3.0, 3.0]],
radii=[1.0, 2.0, 3.0]
)
There was a problem hiding this comment.
Agreed. I've been lazy because pformat is annoying. Threw in some regex to address that 🙄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archetype.__str__was broken at some point. This PR fixes it. It also adds a (small) test.Before:
After: