Skip to content

Remove unused mesh-to-sdf pixi dependency #9263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 11, 2025

Mesh-to-sdf demo was recently removed (iirc as part of numpy update)
We had the pixi dependency for this still lingering.

Hopefully my pixi 0.42.1 doesn't cause issue with pixi 0.41 that is used on ci...

  • pass main ci

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
c584818 https://rerun.io/viewer/pr/9263 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Mar 11, 2025

Latest documentation preview deployed successfully.

Result Commit Link
c584818 https://landing-h2wnb41o0-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member Author

Wumpf commented Mar 12, 2025

@rerun-bot full-check

Copy link

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Any reason not to downgrade to 0.41?)

@Wumpf
Copy link
Member Author

Wumpf commented Mar 12, 2025

🤷

@Wumpf
Copy link
Member Author

Wumpf commented Mar 12, 2025

main ci failed with known failure. good enough I reckon

@Wumpf Wumpf merged commit 632ae49 into main Mar 12, 2025
83 of 86 checks passed
@Wumpf Wumpf deleted the andreas/remove-unused-pixi-dep branch March 12, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants