Skip to content

Fix columns for columns of multiple batch-length==1 fixed size arrays #9262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 11, 2025

Related

What

In other words, the following snippet broke (which got caught by now-red main ci! phew!)

rr.send_columns(
    "box",
    indexes=[rr.IndexColumn("tick", sequence=range(1, 101))],
    columns=rr.Transform3D.columns(
        translation=[[0, 0, t / 10.0] for t in range(100)],
        rotation_axis_angle=[
            rr.RotationAxisAngle(axis=[0.0, 1.0, 0.0], radians=truncated_radians(t * 4)) for t in range(100)
        ],
    ),
)

rotation_axis_angle worked fine, but translation broke because the columns call incorrectly assumed that it's 100 columns (correct) each with a batch size of 3 elements (very wrong).

  • pass full-ci

@Wumpf Wumpf added 🐍 Python API Python logging API 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
5686c9e https://rerun.io/viewer/pr/9262 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member Author

Wumpf commented Mar 11, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13793625415

@Wumpf
Copy link
Member Author

Wumpf commented Mar 11, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13795028977

@abey79 abey79 merged commit 675c6cf into main Mar 12, 2025
80 of 81 checks passed
@abey79 abey79 deleted the andreas/python/fix-column-logging-single-element-fixed-size-arrays branch March 12, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants