Check dataset version when loading LeRobot dataset #9233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
teh-cmc
approved these changes
Mar 10, 2025
| return false; | ||
| } | ||
|
|
||
| ["meta_data", "data"].iter().all(|subdir| { |
There was a problem hiding this comment.
This needs a comment pointing out the difference with v2 -- this took me a while lol.
Also, is there really nothing better we can do here? 😭
There was a problem hiding this comment.
Added a comment.
I can't really think of any other method that doesn't require us to parse the actual dataset info file. The schema is a bit different between v1 and v2 datasets, so we'd have to parse it differently.
oxkitsune
force-pushed
the
gijs/check-lerobot-version
branch
from
0788b2e to
a4024f9
Compare
Wumpf
requested changes
Mar 10, 2025
Wumpf
approved these changes
Mar 10, 2025
jprochazk
pushed a commit
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
The loader now explicitly validates the dataset version, preventing unexpected behavior or silent failures due to unsupported dataset versions.