-
Notifications
You must be signed in to change notification settings - Fork 483
Introduce IndexCell
#9226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IndexCell
#9226
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
41b2f35
to
94d21df
Compare
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13718027176 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"nonstatic" sounds a bit weird, but I guess we gotta stay away from "temporal" if we want to move towards generic indexes... 🤷
Good point 🤔 |
Related
What
Introduces a new type,
IndexCell
:And changes
TimePoint
to use it:Naming
The thought behind the name
IndexCell
is two-fold:A) It is symmetrical with
DataCell
B) It will allow us to at some point broaden to more types of indices (e.g. UUID)
I’d like to rename
TimeType
toIndexType
at some point. I haven’t planned this in detail though; I mostly want to avoid having to rename the new things I add.TODO
Future work
There are A LOT of tests using
Timeline
andTimeInt
that would be better seved by usingTimelineName
andIndexCell
, but this is too much to clean up in this PR.There is also A LOT of (old) parameters of the type
impl TryInt<TimeInt>
which in effect means "An i64 or TimeInt that will be converted to a non-staticTimeInt
via saturating cast". It took me a long time to figure out that this is what it meant. We should come up with a nicer pattern for this.Maybe deprecate
TimePoint::with
andTimePoint::insert
?