-
Notifications
You must be signed in to change notification settings - Fork 482
Remove deprecated Python APIs: log_components
, connect
, connect_tcp
#9197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2bfe327
Remove deprecated `log_components` API
abey79 d3b2a56
Remove deprecated `connect` and `connect_tcp` APIs
abey79 471d137
Add note in migration guide
abey79 d9029f8
Lint + remove connect from python docs
abey79 bed4053
Clarified migration guide
abey79 b42d46a
Fix cross-references to `connect_grpc`
abey79 cedd0d8
lint :/
abey79 bda75d3
proper links
abey79 bb1356d
Merge branch 'main' into antoine/remove-deprecated-apis
abey79 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,6 @@ | |
from typing import Optional, Union | ||
|
||
import rerun_bindings as bindings | ||
from typing_extensions import deprecated # type: ignore[misc, unused-ignore] | ||
|
||
from .._baseclasses import AsComponents, ComponentBatchLike | ||
from .._spawn import _spawn_viewer | ||
|
@@ -562,42 +561,6 @@ def _ipython_display_(self) -> None: | |
|
||
Viewer(blueprint=self).display() | ||
|
||
@deprecated( | ||
"""Please migrate to `connect_grpc(…)`. | ||
See: https://www.rerun.io/docs/reference/migration/migration-0-22 for more details.""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well that turned out to be a lie 😬 |
||
) | ||
def connect( | ||
self, | ||
application_id: str, | ||
*, | ||
url: str | None = None, | ||
make_active: bool = True, | ||
make_default: bool = True, | ||
) -> None: | ||
""" | ||
Connect to a remote Rerun Viewer on the given HTTP(S) URL and send this blueprint. | ||
|
||
Parameters | ||
---------- | ||
application_id: | ||
The application ID to use for this blueprint. This must match the application ID used | ||
when initiating rerun for any data logging you wish to associate with this blueprint. | ||
url: | ||
The HTTP(S) URL to connect to | ||
make_active: | ||
Immediately make this the active blueprint for the associated `app_id`. | ||
Note that setting this to `false` does not mean the blueprint may not still end | ||
up becoming active. In particular, if `make_default` is true and there is no other | ||
currently active blueprint. | ||
make_default: | ||
Make this the default blueprint for the `app_id`. | ||
The default blueprint will be used as the template when the user resets the | ||
blueprint for the app. It will also become the active blueprint if no other | ||
blueprint is currently active. | ||
|
||
""" | ||
return self.connect_grpc(application_id, url=url, make_active=make_active, make_default=make_default) | ||
|
||
def connect_grpc( | ||
self, | ||
application_id: str, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.