Skip to content

Update test and snippets using new_recording() to _actually_ use the stateless API #9196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Mar 5, 2025

Related

What

Some (too little imo) existing snippets and test explicitly create a recording stream but didn't use its API, relying on the recording=rec shenanigans. This PR fixes this.

@abey79 abey79 added 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 5, 2025
Copy link
Member

@oxkitsune oxkitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! might make sense to include something similar in #9148

@abey79
Copy link
Member Author

abey79 commented Mar 5, 2025

this is great! might make sense to include something similar in #9148

Indeed, that PR needs to be up to new standards. I'll drop a comment or two!

@abey79 abey79 merged commit b6e0a55 into main Mar 5, 2025
40 of 41 checks passed
@abey79 abey79 deleted the antoine/update-example-rec branch March 5, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants