Python API: Rename `sequence` time parameter to `seq` #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

emilk wants to merge 4 commits into main from emilk/seq

Member

emilk commented Mar 5, 2025

This makes it the same as the existing APIs for TimeInt and TimeRangeBoundary.

It is also shorter.

Related

Part of Add a timeline type for relative time #8635


          Python API: Rename sequence time parameter to seq

862a99f

This makes it the same as the existing APIs for `TimeInt` and
`TimeRangeBoundary`.

It is also shorter.

github-actions bot commented Mar 5, 2025 •

edited

Loading

Latest documentation preview deployed successfully.

Result	Commit	Link
✅	`2b9db88`	https://landing-c7v5bg3av-rerun.vercel.app/docs

^{Note: This comment is updated whenever you push a commit.}

github-actions bot commented Mar 5, 2025 •

edited

Loading

Web viewer built successfully. If applicable, you should also test it:

I have tested the web viewer

Result	Commit	Link	Manifest
✅	`2b9db88`	https://rerun.io/viewer/pr/9192	`+nightly` `+main`

^{Note: This comment is updated whenever you push a commit.}

emilk added 🐍 Python API exclude from changelog labels

emilk mentioned this pull request

Add a timeline type for relative time #8635

Closed

11 tasks

abey79 self-requested a review

March 5, 2025 13:14

abey79 approved these changes

View reviewed changes

Member

abey79 left a comment

LGTM, except maybe best revert these 0.17 migration things altogether.

Also, when you rebase, there will some more renaming to be doing in the RecordingStream methods.

docs/content/reference/migration/migration-0-17.md Outdated Show resolved Hide resolved

emilk added 3 commits

March 5, 2025 16:38


          Revert old migration guide

28b6d86


          Merge branch 'main' into emilk/seq

cf255cc

# Conflicts:
#	rerun_py/rerun_sdk/rerun/blueprint/api.py


          Update the duplicated code in recording_stream.py

2b9db88

Member Author

emilk commented Mar 6, 2025

It'll be easier to do this from scratch then fixing those merge conflicts

emilk closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog 🐍 Python API