Skip to content

Add rr.IndexColumn #9179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 5, 2025
Merged

Add rr.IndexColumn #9179

merged 11 commits into from
Mar 5, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 4, 2025

@emilk emilk added the 🐍 Python API Python logging API label Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

Latest documentation preview deployed successfully.

Result Commit Link
b9ff405 https://landing-2b8q09lsj-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@emilk
Copy link
Member Author

emilk commented Mar 4, 2025

@rerun-bot full-check

Copy link

github-actions bot commented Mar 4, 2025

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13662704443

@emilk emilk mentioned this pull request Mar 3, 2025
11 tasks
@teh-cmc teh-cmc self-requested a review March 5, 2025 08:24
Copy link

github-actions bot commented Mar 5, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
b9ff405 https://rerun.io/viewer/pr/9179 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk
Copy link
Member Author

emilk commented Mar 5, 2025

@rerun-bot full-check

Copy link

github-actions bot commented Mar 5, 2025

@@ -22,9 +26,97 @@ def as_arrow_array(self) -> pa.Array:
...


class IndexColumn(TimeColumnLike):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment I made elsewhere: I really wish we stopped introducing new python code in the python SDK, and try to do it all on the Rust side if possible (like e.g. @jleibs' dataframe APIs).

@emilk emilk merged commit 17157f1 into main Mar 5, 2025
36 of 37 checks passed
@emilk emilk deleted the emilk/new-time-column-api branch March 5, 2025 09:30
@emilk emilk mentioned this pull request Apr 11, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants