Fix support for numpy-2 #9109
Fix support for numpy-2 #9109
Conversation
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
The last Intel MacBook was released 2021, which is not that long ago (feels like it's been a decade). Still, I feel pretty OK with dropping support for it. I really doubt there are a lot of intel Mac developers out there. |
| PLATFORM: macos-x64 | ||
| WHEEL_ARTIFACT_NAME: macos-x64-wheel | ||
| secrets: inherit | ||
| # TODO(#9108): Test macos wheels |
There was a problem hiding this comment.
I'm afraid that will backfire, but I don't see a way around it, and this PR answers an actual, pressing need. So yeah, let's take the plunge.
pixi.toml
Outdated
| platforms = ["linux-64", "linux-aarch64", "osx-arm64", "osx-64", "win-64"] | ||
| platforms = ["linux-64", "osx-arm64", "win-64"] |
There was a problem hiding this comment.
While osx-64 is in definitely in the past, im afraid linux-aarch64 is in the future. We'll have to deal with that sooner than later.
pixi.toml
Outdated
| @@ -658,22 +665,6 @@ stdio = { path = "examples/python/stdio", editable = true } | |||
| structure_from_motion = { path = "examples/python/structure_from_motion", editable = true } | |||
|
|
|||
| # TODO(jleibs): Do this with less duplication | |||
To be clear: we are not dropping support for intel macs. We still build and publish wheels for them. We just can't run our unit-tests until we fix: #9108 |
What
test_any_values.py#9105AnyValueis having issues with numpy 2 (?) #8486In order to move our pixi project to numpy to, we also had to upgrade pytorch to 2.3+ (we might consider jumping all the way to 2.6, but I was trying to find the minimum bump to risk breaking other things).
Unfortunately torch-2.2 is the last version that supported intel macs.
I disabled the wheel-testing on nightly with an issue to re-enable: #9108