Fix non-final releases creating final-release git tags #9085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
Wumpf
changed the title
jprochazk
approved these changes
Feb 19, 2025
Co-authored-by: Jan Procházka <[email protected]>
oxkitsune
pushed a commit
that referenced
this pull request
Feb 19, 2025
Co-authored-by: Jan Procházka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
0.22.0 GH release & branch was incorrectly created on the RC1 commit
This causes all our release artifacts (and thus cargo binstall) to point at RC1.
This is a bit of a problem as it messes with all sort of things. Luckily the main release artifact that people download from there is the C++ SDK which is close not not affected at all (it does have the RC1 version backed in there though as well, so it doesn't line up with e.g. python installed viewer)
This was triggered by a mistake in a PR right after 0.21 which caused us to create non-rc git tags on rc builds which then caused failures on the actual release. Those were missed, very likely because we had other spurious issues